Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test PBS directives formatter #3356

Merged
merged 1 commit into from
Sep 17, 2019

Conversation

matthewrmshin
Copy link
Contributor

@matthewrmshin matthewrmshin commented Sep 10, 2019

Add unit test for the directives formatter function for PBS handler.

Also upgrade default PBS job name line length from 15 to 236, i.e. assuming PBS version >=13.

This is a small change with no associated Issue. The purpose is to observe the test coverage of a source file that is currently untested on Travis CI.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Appropriate tests are included (unit and/or functional).
  • Appropriate change log entry included.

@matthewrmshin matthewrmshin added this to the cylc-8.0a2 milestone Sep 10, 2019
@matthewrmshin matthewrmshin self-assigned this Sep 10, 2019
@matthewrmshin
Copy link
Contributor Author

From 54.55% to 100%. 🎉

Upgrade default PBS job name line length from 15 to 236, i.e. assuming PBS
version >=13.
@hjoliver hjoliver merged commit 0d8a299 into cylc:master Sep 17, 2019
@matthewrmshin matthewrmshin modified the milestones: cylc-8.0a2, cylc-8.0a1 Sep 17, 2019
@matthewrmshin matthewrmshin deleted the unittest-batch_sys_handlers-pbs branch September 17, 2019 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants